[Webkit-unassigned] [Bug 53899] [Chromium][DRT] some PostDelayedTask() accesses possibly dangling this pointer.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53899





--- Comment #3 from Kent Tamura <tkent at chromium.org>  2011-02-17 01:17:17 PST ---
(From update of attachment 82766)
View in context: https://bugs.webkit.org/attachment.cgi?id=82766&action=review

> Tools/DumpRenderTree/chromium/WebViewHost.cpp:419
> +    postDelayedTask(new WebViewHost::HostMethodTask(this, &WebViewHost::finishLastTextCheck), 0);

"WebViewHost::" looks redundant.

> Tools/DumpRenderTree/chromium/WebViewHost.cpp:662
> +    postDelayedTask(new WebViewHost::HostMethodTask(this, &WebViewHost::scheduleComposite), 0);

ditto.

> Tools/DumpRenderTree/chromium/WebViewHost.cpp:709
> +    postDelayedTask(new WebViewHost::HostMethodTask(this, &WebViewHost::closeWidget), 0);

ditto.

> Tools/DumpRenderTree/chromium/WebViewHost.h:70
> +    class HostMethodTask : public MethodTask<WebViewHost> {

Do we need to make this class public?

> Tools/DumpRenderTree/chromium/WebViewHost.h:76
> +        {}

nit: We usually use "{ }" (a blank between {}).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.