[Webkit-unassigned] [Bug 54622] Rename Position::node() to Position::deprecatedNode()
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 17 01:09:26 PST 2011
https://bugs.webkit.org/show_bug.cgi?id=54622
WebKit Review Bot <webkit.review.bot at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |webkit.review.bot at gmail.com
--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com> 2011-02-17 01:09:26 PST ---
Attachment 82765 did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Last 3072 characters of output:
he left side of the line instead of the right side. [whitespace/operators] [4]
Source/WebCore/editing/ReplaceSelectionCommand.cpp:796: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Source/WebCore/editing/CompositeEditCommand.cpp:732: An else should appear on the same line as the preceding } [whitespace/newline] [4]
Source/WebCore/editing/DeleteSelectionCommand.cpp:510: Declaration has space between type name and * in Text *text [whitespace/declaration] [3]
Source/WebCore/editing/DeleteSelectionCommand.cpp:523: Declaration has space between type name and * in Node *n [whitespace/declaration] [3]
Source/WebCore/dom/Position.cpp:390: Declaration has space between type name and * in RenderText *textRenderer [whitespace/declaration] [3]
Source/WebCore/dom/Position.cpp:411: Declaration has space between type name and * in Node *fromRootEditableElement [whitespace/declaration] [3]
Source/WebCore/dom/Position.cpp:439: Declaration has space between type name and * in Node *fromRootEditableElement [whitespace/declaration] [3]
Source/WebCore/dom/Position.cpp:767: Declaration has space between type name and * in RenderObject *renderer [whitespace/declaration] [3]
Source/WebCore/dom/Position.cpp:803: Declaration has space between type name and * in RenderObject *renderer [whitespace/declaration] [3]
Source/WebCore/dom/Position.cpp:863: Declaration has space between type name and * in RenderObject *renderer [whitespace/declaration] [3]
Source/WebCore/dom/Position.cpp:867: Declaration has space between type name and * in RenderObject *posRenderer [whitespace/declaration] [3]
Source/WebCore/dom/Position.cpp:931: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Source/WebCore/dom/Position.cpp:932: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Source/WebCore/dom/Position.cpp:936: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Source/WebCore/dom/Position.cpp:937: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Source/WebCore/editing/ApplyStyleCommand.cpp:673: Declaration has space between type name and * in Node *startNode [whitespace/declaration] [3]
Source/WebCore/editing/htmlediting.cpp:886: Declaration has space between type name and * in Node *node [whitespace/declaration] [3]
Source/WebCore/editing/InsertTextCommand.cpp:171: Declaration has space between type name and * in Text *textNode [whitespace/declaration] [3]
Source/WebCore/editing/InsertTextCommand.cpp:212: Declaration has space between type name and * in Node *node [whitespace/declaration] [3]
Total errors found: 31 in 44 files
If any of these errors are false positives, please file a bug against check-webkit-style.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list