[Webkit-unassigned] [Bug 53705] Viewport parsing no longer accepts "1.0; " value as valid.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53705





--- Comment #17 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2011-02-17 00:46:14 PST ---
(From update of attachment 82738)
View in context: https://bugs.webkit.org/attachment.cgi?id=82738&action=review

> LayoutTests/ChangeLog:17
> +        FIXME: OTHER TESTS WOULD BE AFFECTED.
> +        fast/viewport/viewport-65.html and potentially others.
> +        ------

Notice that the Qt port already skips a few of the tests.

> Source/WebCore/dom/ViewportArguments.cpp:182
> +static float numericPrefix(const String& keyString, const String& valueString, Document* document, bool* ok)

The valueString and the ok are related to the actual parsing here, where as the keyString and the document are used for error reporting.

What about:

numericPrefix(const String& valueString, bool* ok, ViewportErrorCode* error)

We could then even add a NoError to the ViewportErrorCode if we wanted.

> Source/WebCore/dom/ViewportArguments.cpp:192
> +        if (!isASCIIDigit(firstChar) || (firstChar == '-' && !isASCIIDigit(valueString[1]))) {

What if there is only the firstChar as - and no second one?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.