[Webkit-unassigned] [Bug 54529] GeolocationPosition to store timestamp as integer in miliseconds

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54529





--- Comment #5 from Mahesh Kulkarni <mahesh.kulkarni at nokia.com>  2011-02-16 19:36:00 PST ---
(In reply to comment #2)
> Well remembered, Steve. I did ask Sam about this issue in an email, and he told me that it made more sense to use double in the C (as opposed to DOM)  APIs since that is what has been historically used.
> 
> Are there any examples of WebCore using integer milliseconds in non-DOM classes ?

I'm not sure why DOMTimerStamp cant be used in non-dom class? When I grep for it I get few hits. As DOMTimerStamp is long long type, I think its more aligned to have the same data type for holding miliseconds value. 

Also greping for convertSecondsToDOMTimeStamp() fetched only geolocaiton usecase like, Event where currentTime() is used to store DOMTImerStamp obect. IMO Event.cpp should be calling currentTimeMS() and replace those C type of functions altogether.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.