[Webkit-unassigned] [Bug 54533] [NRWT] new-run-webkit-test should find DumpRenderTree even if 'ninja' is used as a build system.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54533





--- Comment #8 from Hayato Ito <hayato at chromium.org>  2011-02-16 19:06:54 PST ---
Thank you for the review.

(In reply to comment #7)
> (From update of attachment 82600 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=82600&action=review
> 
> adding evan to this. Evan, is ninja intentionally ignoring the configuration? That doesn't seem like a good thing.
> 
> > Tools/Scripts/webkitpy/layout_tests/port/chromium_linux.py:94
> > +                    if arg.lower() not in ['release', 'debug', 'default']]
> 
> This is kind of an ugly hack. If it is correct that ninja ignores the configuration, then I think it would be better to change the signature of _build_path() to be def _build_path(configuration, binary) and then just ignore the configuration parameter here. 
> 
> However, I'm not real comfortable with ninja ignoring the configuration. That seems like it could cause bad things could happen and is unlike all of our other builds.

I agree that this is an ugly hack. I've taken look at code of ninja (tools/gyp/pylib/gyp/generator/ninja.py), and it doesn't seem to be difficult to let ninja use different directory (say, ninja/Debug or ninja/Release) according to given configuration, looking at "-Gconfig" option.

Evan, what do you think about this?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.