[Webkit-unassigned] [Bug 54588] [chromium] Roll Chromium DEPS to 75190

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54588





--- Comment #13 from Sergey Ulanov <sergeyu at chromium.org>  2011-02-16 17:44:38 PST ---
(In reply to comment #12)
> (In reply to comment #11)
> > (In reply to comment #10)
> > > +Albert
> > > 
> > > No idea why DumpRenderTree is now dependent on libjingle.
> > > 
> > > Albert - The only thing that depends on libjingle afaik is remoting. Any idea what would cause DumpRenderTree to now rely on it (changed sometime between now (Weds 5pm PST) and 30 hours ago (Tues, 11am PST).
> > 
> > +Sergey
> > 
> > Actually, there's a few places that depend on libjingle (eg., sync).
> > 
> > Also, we're starting to use it in PPAPI (albeit to support remoting and similar use cases, but technically its a separate feature).
> > 
> > The CL that added the dependency is this:
> >    http://codereview.chromium.org/6478018
> > 
> > I think the larger question is if DRT needs to depend on PPAPI...it's just testing the webkit renderer right?  Do we actually need pepper plugins for that?
> 
> Indeed.  I think eventually we might want to run layout tests that test pepper plugins (we currently have layout tests for NPAPI plugins), but we don't currently have any such layout tests.
> 
> It sucks that we keep having to add more and more (large) dependencies to this checkout.  It increases the complexity of rolling, build+cycle times, and makes it harder to understand what's going on with the code.

In future I plan to add an abstract interface for P2P, so it will be possible to mock it for layout tests, but I'm not sure if it worth it (do we need to test the full network stack in the layout tests?).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.