[Webkit-unassigned] [Bug 54585] [fileapi] Implement EntrySync.toURI by moving Entry::toURI to EntryBase

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 16 17:23:29 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=54585





--- Comment #6 from Eric U. <ericu at chromium.org>  2011-02-16 17:23:29 PST ---
(In reply to comment #5)
> (From update of attachment 82689 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=82689&action=review
> 
> >> LayoutTests/fast/filesystem/resources/file-entry-to-uri-sync.js:11
> >> +shouldBe("testFileEntry.toURI()", "'filesystem:file:///temporary/testFileEntry.txt'");
> > 
> > Are we forcing all URLs to start with three slashes, then--two for the protocol, and one for "it's from the root"?  It seems like the third one should be superfluous, as the root is implied.  I realize this is beyond the scope of this CL, but apparently I missed it in the last one.
> 
> I think the three slashes in a row here are due simply to the way the file: URI scheme works (and how SecurityOrigin::toString deals with it).  The first two slashes are part of the security origin: "file://". The third slash separates the origin from the filesystem type ("permanent" or "temporary").  Without this, "normal" http-based filesystme URIs would be unparseable: that last slash keeps these from reading "http://www.google.comtemporary/foo/bar.txt".
> 
> It just so happens that the "host" part of the origin is empty for file: URIs.  Does that make sense? Or am I missing your point?

Oh, OK--nevermind then.  Looks like it's not a problem.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list