[Webkit-unassigned] [Bug 54516] [chromium] Add code to WebView to allow Chromium access to NetworkStateNotifier

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54516





--- Comment #5 from Adam Klein <adamk at chromium.org>  2011-02-16 12:02:07 PST ---
(From update of attachment 82562)
View in context: https://bugs.webkit.org/attachment.cgi?id=82562&action=review

>> Source/WebKit/chromium/public/WebView.h:370
>> +    WEBKIT_API static void networkStateChange(bool onLine);
> 
> nit: I'm not sure that this makes best sense on WebView.  Other things in WebKit could
> care about the network state.  A new, separate header file would be OK, even though it
> would only have a single method in it.
> 
> Also, it is increasingly popular in WebKit code to avoid functions that just take a bool
> parameter (unless the function is a setter for a boolean property).  Instead, people
> prefer using enums or separate functions so that code at call-sites is more readable.

Thanks for the feedback, this is my first time extending the WebKit API so I knew I'd make some blunders.  I've created WebNetworkStateNotifier.{h,cpp}, and changed both it and WebCore::NetworkStateNotifier to use an enum to pass this information.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.