[Webkit-unassigned] [Bug 50916] Add support for dir=auto

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50916


Dave Hyatt <hyatt at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81841|review?                     |review-
               Flag|                            |




--- Comment #30 from Dave Hyatt <hyatt at apple.com>  2011-02-16 11:16:13 PST ---
(From update of attachment 81841)
View in context: https://bugs.webkit.org/attachment.cgi?id=81841&action=review

Much better in HTMLElement.  Just one concern:

> Source/WebCore/html/HTMLElement.cpp:1005
> +    if (childCountDelta > 0) {
> +        Node* node = beforeChange ? beforeChange->traverseNextSibling() : 0;
> +        for (int counter = 0; node && counter < childCountDelta; counter++, node = node->traverseNextSibling()) {
> +            if (node->isElementNode() && toElement(node)->hasAttribute(dirAttr))
> +                continue;
> +
> +            setHasDirAutoFlagRecursively(node, false);
> +        }
> +    }

This code concerns me.  It seems like it's going to run on every childrenChanged call?  This seems like an obvious performance hit.  Does this code really have to run all the time, or did you mean to put it below the if check?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.