[Webkit-unassigned] [Bug 54542] SVG animation - analyze attribute type for animation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54542





--- Comment #2 from Nikolas Zimmermann <zimmermann at kde.org>  2011-02-16 10:53:22 PST ---
(From update of attachment 82632)
View in context: https://bugs.webkit.org/attachment.cgi?id=82632&action=review

> Source/WebCore/ChangeLog:9
> +        SVG animation - analyze attribute type for animation
> +        https://bugs.webkit.org/show_bug.cgi?id=54542

Redundant.

> Source/WebCore/svg/SVGAnimateElement.cpp:136
> +    DEFINE_STATIC_LOCAL(const AtomicString, xlinkHref, ("xlink:href"));
> +
> +    // xlink:href is the only animated attribute outside of SVG.
> +    const String attributeName = this->attributeName();
> +    QualifiedName attrName(QualifiedName(nullAtom, attributeName, nullAtom));
> +    if (attributeName == xlinkHref)
> +        attrName = XLinkNames::hrefAttr;

This is definately not correct.
I'm sure we can construct a QualifiedName that works for SVG & XLink (and any other possible namespace) w/o having to declare static strings here.
Let's talk on IRC.

> Source/WebCore/svg/SVGAnimateElement.cpp:142
> +    if (type == AnimatedBoolean

A big FIXME here, that animations works this way at the moment, and we want to avoid "most types -> AnimatedString" in the future.

> Source/WebCore/svg/SVGGElement.h:54
> +    virtual void fillAttributeToPropertyTypeMap();
> +    virtual AttributeToPropertyTypeMap& attributeToPropertyTypeMap();

Why is this needed?

> Source/WebCore/svg/SVGUseElement.cpp:245
> +    attributeToPropertyTypeMap.set(XLinkNames::hrefAttr, AnimatedString);

Oops!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.