[Webkit-unassigned] [Bug 54387] V8 3.1.4 changed value of Math.LOG10E

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54387





--- Comment #6 from Peter Kasting <pkasting at google.com>  2011-02-16 10:19:38 PST ---
(In reply to comment #5)
> The patch adds the file
> 
>   LayoutTests/platform/chromium/fast/js/kde/math-expected.txt
> 
> which only differs from
> 
>   LayoutTests/fast/js/kde/math-expected.txt
> 
> in the result of Math.LOG10E is
> 
>   0.4342944819032518
> 
> in the first and
> 
>   0.43429448190325176
> 
> in the second.
> 
> Should that not cover the difference in the value of Math.LOG10E between V8 and JSC?

No, because the test explicitly checks the value against 0.43429448190325176.  That's why the current output is "FAIL" + explanation instead of the output you attached.  Please see the actual test source code at http://trac.webkit.org/browser/trunk/LayoutTests/fast/js/kde/script-tests/math.js.

The best patch might be one that changes the test to expect the more-correct value, changes the global expectation to expect failure, and adds a Chromium expectation identical to the one you supplied.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.