[Webkit-unassigned] [Bug 49345] Add Support to WebCore to optionally call an optional platform-specific gesture recognizer

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 16 09:03:19 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=49345





--- Comment #34 from Benjamin Poulain <benjamin.poulain at nokia.com>  2011-02-16 09:03:18 PST ---
(From update of attachment 82649)
View in context: https://bugs.webkit.org/attachment.cgi?id=82649&action=review

> Source/WebCore/page/EventHandler.cpp:3063
> +PassOwnPtr<PlatformGestureRecognizer> EventHandler::gestureRecognizer()
> +{
> +    return m_gestureRecognizer.release();
> +}
> +
> +void EventHandler::setGestureRecognizer(PassOwnPtr<PlatformGestureRecognizer> g)
> +{
> +    m_gestureRecognizer = g;
> +}

Why do we need getters and setters AND createPlatformGestureRecognizer(). Do you have use case to change the recognizer at runtime?

> Source/WebCore/platform/PlatformGestureRecognizer.cpp:40
> +// here that meets its needs. EventSender will ignore null GestureRecognizers.

EventSender?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list