[Webkit-unassigned] [Bug 54557] [GTK] libsoup critical warnings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54557





--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2011-02-16 08:35:25 PST ---
(From update of attachment 82639)
View in context: https://bugs.webkit.org/attachment.cgi?id=82639&action=review

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:703
> +    SoupMessage* soupMessage = d->m_soupMessage.get();
> +    if (SOUP_STATUS_IS_SUCCESSFUL(soupMessage->status_code))
> +        return;

Hrm. Wouuld it be better to check for soupMessage->status_code != SOUP_STATUS_NONE? We don't want to cancel the message if it's finished for any reason.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.