[Webkit-unassigned] [Bug 54535] Stop calling node() and deprecatedEditingOffset() in comparePositions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54535





--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org>  2011-02-16 00:15:18 PST ---
(From update of attachment 82597)
View in context: https://bugs.webkit.org/attachment.cgi?id=82597&action=review

> Source/WebCore/dom/CharacterData.cpp:156
> -    if (document()->frame())
> -        document()->frame()->selection()->textWillBeReplaced(this, offsetOfReplacedData, oldLength, newLength);
>      RefPtr<StringImpl> oldData = m_data;
>      m_data = newData;
> +    if (document()->frame())
> +        document()->frame()->selection()->textWillBeReplaced(this, offsetOfReplacedData, oldLength, newLength);

This change is required because computeOffsetInContainerNode() auto-corrects the offset and causes VisibleSelection::setWithoutValidation to set m_baseIsFirst incorrectly when new offset is larger than the maximum offset in the oldData.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.