[Webkit-unassigned] [Bug 54313] Need didReceiveCachedMetadata, and finishTime for didFinishLoading exposed in ThreadableLoaderClient.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54313





--- Comment #28 from Bill Budge <bbudge at gmail.com>  2011-02-15 18:07:48 PST ---
(From update of attachment 82553)
View in context: https://bugs.webkit.org/attachment.cgi?id=82553&action=review

>> Source/WebCore/loader/DocumentThreadableLoader.cpp:243
>> +    ASSERT_UNUSED(loader, loader == m_loader);
> 
> I think this is missing the following:
> 
> if (!m_actualRequest)
>     m_client->didReceiveCachedMetadata(data, lengthReceived)

Good catch!

>> Source/WebCore/loader/DocumentThreadableLoader.h:49
>> +    class DocumentThreadableLoader : public RefCounted<DocumentThreadableLoader>, public ThreadableLoader, protected SubresourceLoaderClient  {
> 
> "protected SubresourceLoaderClient" should be "private SubresourceLoaderClient" again.

Done.

>> Source/WebCore/loader/DocumentThreadableLoader.h:57
>> +        virtual void setDefersLoading(bool);
> 
> I suspect that you'll need to make this method public.

It is.

>> Source/WebCore/loader/DocumentThreadableLoader.h:78
>> +        virtual void didDownloadData(SubresourceLoader*, int dataLength);
> 
> This isn't implemented in DocumentThreadableLoader.cpp (and I doubt that it should be here).

Right, and it breaks the build on Linux.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.