[Webkit-unassigned] [Bug 54313] ThreadableLoaderClient doesn't support WebURLLoader usage.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54313


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82553|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #26 from David Levin <levin at chromium.org>  2011-02-15 17:44:49 PST ---
(From update of attachment 82553)
View in context: https://bugs.webkit.org/attachment.cgi?id=82553&action=review

Just a few things to clean up.

> Source/WebCore/loader/DocumentThreadableLoader.cpp:243
> +    ASSERT_UNUSED(loader, loader == m_loader);

I think this is missing the following:

if (!m_actualRequest)
    m_client->didReceiveCachedMetadata(data, lengthReceived)

> Source/WebCore/loader/DocumentThreadableLoader.h:49
> +    class DocumentThreadableLoader : public RefCounted<DocumentThreadableLoader>, public ThreadableLoader, protected SubresourceLoaderClient  {

"protected SubresourceLoaderClient" should be "private SubresourceLoaderClient" again.

> Source/WebCore/loader/DocumentThreadableLoader.h:57
> +        virtual void setDefersLoading(bool);

I suspect that you'll need to make this method public.

> Source/WebCore/loader/DocumentThreadableLoader.h:78
> +        virtual void didDownloadData(SubresourceLoader*, int dataLength);

This isn't implemented in DocumentThreadableLoader.cpp (and I doubt that it should be here).

> Source/WebCore/xml/XMLHttpRequest.cpp:990
> +void XMLHttpRequest::didFinishLoading(unsigned long identifier, double finishTime)

This will likely result in a compile error since "finishTime" isn't used in this function (just omit the parameter name).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.