[Webkit-unassigned] [Bug 53281] To determine image properties, CG allocates memory which isn't included in CachedImage's decoded size

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53281


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80810|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #14 from Darin Adler <darin at apple.com>  2011-02-15 14:33:55 PST ---
(From update of attachment 80810)
View in context: https://bugs.webkit.org/attachment.cgi?id=80810&action=review

> Source/WebCore/platform/graphics/BitmapImage.cpp:163
> +#ifndef NDEBUG
> +    bool overflow = updatedSize > m_decodedPropertiesSize && deltaBytes < 0;
> +    bool underflow = updatedSize < m_decodedPropertiesSize && deltaBytes > 0;
> +    ASSERT(!overflow && !underflow);
> +#endif

I know I raised the possibility of overflow. But I don’t think an assertion really helps much. The worry about overflow is it actually happening in the field, not happening on a debug build.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.