[Webkit-unassigned] [Bug 54313] DocumentThreadableLoader doesn't support WebURLLoader usage.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54313





--- Comment #15 from David Levin <levin at chromium.org>  2011-02-15 12:50:30 PST ---
(In reply to comment #14)
> Let me rephrase that: Do I need to worry about that before calling the client in a derived implementation of didReceiveCachedMetadata?

Good point! I would.

When a request is done that is cross origin, it may trigger a preflight request which is a request to get info from the site to see if the cross origin request is allowed.

This preflight request is a basically protocol detail that shouldn't be exposed to the clients so it is nice to check to see if this is happening and not forward along the info to the client.


(In reply to comment #12)
> (From update of attachment 82479 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=82479&action=review
> 
> >> Source/WebCore/loader/DocumentThreadableLoader.h:80
> >> +        virtual void didReceiveCachedMetadata(SubresourceLoader*, const char*, int lengthReceived);
> > 
> > Do you need this overload? (I though it was only here because SubresourceLoaderClient was private but that is no longer true.)
> 
> I added it so that we could include the assertion logic of the other methods, which verify that it's not called improperly. 

Good point. Feel free to leave it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.