[Webkit-unassigned] [Bug 54464] Rename Color::name() to Color::drtName()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 15 10:07:11 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=54464


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82460|review?                     |review+
               Flag|                            |




--- Comment #4 from Darin Adler <darin at apple.com>  2011-02-15 10:07:11 PST ---
(From update of attachment 82460)
View in context: https://bugs.webkit.org/attachment.cgi?id=82460&action=review

Please use a better name, though!

> Source/WebCore/platform/graphics/Color.h:101
> +    // Returns the color serialized as either #RRGGBB or #RRGGBBAA
> +    // The latter format is not a valid CSS color, and should only be seen in DRT dumps.
> +    String drtName() const;

I suggest nameForDumpRenderTree or nameForRenderTreeDumps, or nameForRegressionTestDumps or nameForLayoutTests or something along those lines. Not a big fan of acronyms, and they are even worse as all lowercase prefixes!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list