[Webkit-unassigned] [Bug 54466] New: [Qt] Qt build system can't handle removing headers from tree

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54466

           Summary: [Qt] Qt build system can't handle removing headers
                    from tree
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Keywords: Qt, QtTriaged
          Severity: Major
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ossy at webkit.org
                CC: hausmann at webkit.org, kenneth at webkit.org,
                    abecsi at webkit.org, kling at webkit.org


(1)
http://trac.webkit.org/changeset/78382 removed JavaScriptCore/runtime/CollectorHeapIterator.h 
from the tree and it caused an incremental build failure, because this header wasn't added
to HEADERS of JavaScriptCore.pro and qmake didn't regenerate makefile:

make[1]: *** No rule to make target `../../../Source/JavaScriptCore/runtime/CollectorHeapIterator.h', needed by `obj/release/Debugger.o'.  Stop.
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory `/home/oszi/WebKit/WebKitBuild/Release/JavaScriptCore'
make: *** [sub-JavaScriptCore-JavaScriptCore-pro-make_default-ordered] Error 2


(2)
https://bugs.webkit.org/attachment.cgi?id=82390 in https://bugs.webkit.org/show_bug.cgi?id=54415
removed Source/JavaScriptCore/runtime/GCHandle.h from the tree and it caused an incremental 
build failure on Qt EWS, because this header wasn't added to HEADERS of WebKit2.pro and 
qmake didn't regenerate makefile:

make[1]: Entering directory `/home/webkit/WebKit-qt-ews/WebKitBuild/Release/WebKit2'
make[1]: *** No rule to make target `../../../Source/JavaScriptCore/runtime/GCHandle.h', needed by `obj/release/ConnectionQt.o'.  Stop.
make[1]: Leaving directory `/home/webkit/WebKit-qt-ews/WebKitBuild/Release/WebKit2'
make: *** [sub-WebKit2-WebKit2-pro-make_default-ordered] Error 2


Unfortunately non-existant dependency cause build breakage. :(
I have ideas how can we fix this kind of failures:
- Remove all MakeFile* from WebKitBuild before building to make qmake regenerate makefiles always
- Add all header files to HEADERS. (It's hard to maintain. eg in case (2) 
  we have to add a JavaScriptCore header to WebKit2.pro)
- Create a new general header.pri for all header files and include it from all pro files

What do you think about this bug?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.