[Webkit-unassigned] [Bug 49989] REGRESSION: Date.parse("Tue Nov 23 20:40:05 2010 GMT") returns NaN

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49989


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82467|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #8 from Darin Adler <darin at apple.com>  2011-02-15 08:59:19 PST ---
(From update of attachment 82467)
View in context: https://bugs.webkit.org/attachment.cgi?id=82467&action=review

I’m not going to say review- just for a comment, but I don’t feel comfortable doing commit-queue+ on this so for now I am doing commit-queue-. Someone else can reverse that if we discuss and decide to land this exactly as-is.

> LayoutTests/fast/js/script-tests/date-parse-test.js:130
> +testDateParse("Wed Dec 25 1:30 1995 GMT", "819855000000");

I am concerned that we are adding only this single test case that is a well formatted date. I am more interested in more ambiguous cases that end up being treated as years. We need to make sure we cover not only legal cases but unusual ones as well.

Can someone add some more test cases?

> Source/JavaScriptCore/wtf/DateMath.cpp:924
> +    // the year may be before the timezone

WebKit project style uses a sentence style for comments. And this one is a sentence. I suggest this comment instead.

    // The year may be after the time but before the time zone.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.