[Webkit-unassigned] [Bug 53916] [Qt] WebKit patches required to work with a modularized version of Qt

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53916





--- Comment #19 from Kristian Amlie <kristian.amlie at nokia.com>  2011-02-15 02:50:55 PST ---
> r- as the I think $$QMAKE_LIBDIR_QT should change as well.

Included in new patch.

> Perhaps we can set $$QT.XX.includes in WebKit.pri depending on the contains QT_CONFIG, modular) test.

This turned out to not be so trivial. The includes are inside a scope "contains(DEFINES, ENABLE_VIDEO=1)", however the define is given by the features.pri profile which is inside the WebCore directory. I'm not intimately familiar with how the building on WebKit works, but I assume that it is kind of bad to make WebKit.pri depend on something that is only present inside one of its subprojects. Or do you disagree?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.