[Webkit-unassigned] [Bug 54439] [EFL] New API for executing Editor Commands: InsertText, InsertImage.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54439





--- Comment #2 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2011-02-15 02:16:29 PST ---
(In reply to comment #1)
> Attachment 82425 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/efl/ChangeLog', u'Source/Web..." exit_code: 1
> 
> Source/WebKit/efl/ewk/ewk_view.h:363:  The parameter name "o" adds no information, so it should be removed.  [readability/parameter_name] [5]
> Source/WebKit/efl/ewk/ewk_view.h:363:  The parameter name "command" adds no information, so it should be removed.  [readability/parameter_name] [5]
> Total errors found: 2 in 3 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

To fix these style errors, you have to remove parameter name as below,

EAPI Eina_Bool    ewk_view_execute_editor_command(Evas_Object*, const Ewk_Editor_Command, const char *value);

However, other APIs have parameter name in ewk_view.h. I don't know if we should remove parameter name in this patch. 

Lucas, how do you think about this ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.