[Webkit-unassigned] [Bug 54439] New: [EFL] New API for executing Editor Commands: InsertText, InsertImage.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54439

           Summary: [EFL] New API for executing Editor Commands:
                    InsertText, InsertImage.
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebKit EFL
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: k.blank at samsung.com



Kamil Blank <k.blank at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82425|                            |review?
               Flag|                            |


Created an attachment (id=82425)
 --> (https://bugs.webkit.org/attachment.cgi?id=82425&action=review)
patch

I'd like to add new functionalities to be executed by EditorCommand - InsertText, InsertImage.
I decided to do it in a different way than previous commands: "SelectWord", "SelectLine" etc. 
I believe that having one function for all commands is much better than tens of similar functions 
(what is possible as EditorCommand has a lot of commands defined).

Due to this fact I was also thinking about replacing existing functions (listed below) by additional enums in Ewk_Editor_Command
but I'm not sure whether removing API is a good idea, what do you think?

List of existing editor commands:
EAPI Eina_Bool    ewk_view_select_none(Evas_Object *o);
EAPI Eina_Bool    ewk_view_select_all(Evas_Object *o);
EAPI Eina_Bool    ewk_view_select_paragraph(Evas_Object *o);
EAPI Eina_Bool    ewk_view_select_sentence(Evas_Object *o);
EAPI Eina_Bool    ewk_view_select_line(Evas_Object *o);
EAPI Eina_Bool    ewk_view_select_word(Evas_Object *o);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.