[Webkit-unassigned] [Bug 53213] Refactoring: Extract TextCheckerClient from EditorClient

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 14 20:07:44 PST 2011


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
  Attachment #82409|review?                     |review+
               Flag|                            |

--- Comment #28 from Ryosuke Niwa <rniwa at webkit.org>  2011-02-14 20:07:43 PST ---
(From update of attachment 82409)
View in context: https://bugs.webkit.org/attachment.cgi?id=82409&action=review

r=me provided you fix copyright statement & a really long comment as described below.

> Source/WebCore/editing/SpellChecker.cpp:46
> -SpellChecker::SpellChecker(Frame* frame, EditorClient* client)
> +SpellChecker::SpellChecker(Frame* frame, TextCheckerClient* client)

Ah, beautiful! Only one line changed in this file.

> Source/WebCore/platform/text/TextCheckerClient.h:18
> + *     * Neither the name of Google Inc. nor the names of its
> + * contributors may be used to endorse or promote products derived from
> + * this software without specific prior written permission.

Mn... you grabbed a wrong version here.  Take a look at EditingStyle.cpp.

> Source/WebCore/platform/text/TextCheckerClient.h:82
> +    // For spellcheckers that support multiple languages, it's often important to be able to identify the language in order to provide more accurate correction suggestions. Caller can pass in more text in "context" to aid such spellcheckers on language identification. Noramlly it's the text surrounding the "word" for which we are getting correction suggestions.

You should split this long sentence into several lines.  On IDEs that permit 1000+ columns per line, this line will be hard to read.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list