[Webkit-unassigned] [Bug 54374] Add method to make BuildBot return test outputs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54374





--- Comment #7 from Ojan Vafai <ojan at chromium.org>  2011-02-14 19:09:27 PST ---
(From update of attachment 82285)
View in context: https://bugs.webkit.org/attachment.cgi?id=82285&action=review

>>>> Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py:97
>>>> +    def latest_build(self):
>>> 
>>> Nit: while I can see why this might be a useful method, it's not actually used in this patch or described in the ChangeLog description. A one-liner in the ChangeLog description of what this is to be used for would be good.
>> 
>> The danger with this method is you don't know if it's cached or not. :)
> 
> I don't understand. You're saying it might be slow?

So, what's the right way to grab the latest build then? Should this not use revision_build_pairs_with_results()? Should this method just be called latest_cached_build? Should builder have an update_cached_builds method?

Seems to me like just calling it latest_cached_build is probably sufficient for now.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.