[Webkit-unassigned] [Bug 54287] SubresourceLoader should expose finish time

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54287


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82397|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #24 from David Levin <levin at chromium.org>  2011-02-14 17:52:13 PST ---
(From update of attachment 82397)
View in context: https://bugs.webkit.org/attachment.cgi?id=82397&action=review

Just some minor nits to address and then this one will be done.

> Source/WebCore/loader/DocumentThreadableLoader.cpp:234
> +void DocumentThreadableLoader::didFinishLoading(SubresourceLoader* loader, double finishTime)

I would leave out the parameter name "finishTime". Since it isn't used in this function, I believe it will cause a compile error (with some builds like the WebKit build on OSX) if you include it.

> Source/WebCore/loader/SubresourceLoaderClient.h:51
> +    virtual void didFinishLoading(SubresourceLoader*, double) { }

It would be good to include the name here /*finishTime*/ like other places so that one can look at this header and tell what this parameter is about.

> Source/WebCore/loader/cache/CachedResourceRequest.cpp:140
> +void CachedResourceRequest::didFinishLoading(SubresourceLoader* loader, double finishTime)

I would leave out the parameter name "finishTime" here. Same reasoning as before.

> Source/WebCore/loader/icon/IconLoader.cpp:134
> +void IconLoader::didFinishLoading(SubresourceLoader* resourceLoader, double finishTime)

I would leave out the parameter name "finishTime" here. Same reasoning as before.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.