[Webkit-unassigned] [Bug 54420] SharedBuffer::buffer() does not do what you think.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54420


Gavin Peters <gavinp at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82382|                            |commit-queue?
               Flag|                            |




--- Comment #3 from Gavin Peters <gavinp at chromium.org>  2011-02-14 16:40:38 PST ---
(From update of attachment 82382)
This patch fixes the issue by removing consumers of SharedBuffer::buffer() and using the safer SharedBuffer::data().

pkasting pointed out (in irc) that there may be further simplification to be had by making all decoders use the same interface.  I believe that!  However this bug was causing chrome to stop displaying images on many sites, and so I made this minimal fix right away.

I'm open to ideas on testing, and also to follow up with more rationalization of how we handle SharedBuffer.

See: http://code.google.com/p/chromium/issues/detail?id=68622 for the chrome bug that brought me here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.