[Webkit-unassigned] [Bug 27798] [chromium] Media control panel for <video> in MediaDocument is mis-placed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 14 14:37:20 PST 2011


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
  Attachment #82363|review?, commit-queue?      |review-
               Flag|                            |

--- Comment #6 from David Levin <levin at chromium.org>  2011-02-14 14:37:20 PST ---
(From update of attachment 82363)
View in context: https://bugs.webkit.org/attachment.cgi?id=82363&action=review

A new bug is preferred for new work/patches -- otherwise it can be confusing to sort through the comments (which pertain to the current patch and which pertain to the old patch).

> Source/WebCore/ChangeLog:13
> +        No new tests. (OOPS!)

This line needs to be replaced :)

A few choices:
1. Indicate what test you're adding.
2. Indicate what test covers the functionality.
3. Indicate why a test isn't necessary (No new functionality, so no new tests.) (Hint that isn't the case here because you're changing something that is visible.)
4. Indicate why a test isn't possible (You should add functionality to dumprendertree if necessary to test, so this is almost never the correct answer.)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list