[Webkit-unassigned] [Bug 54352] [GTK] Match more various WebKit API enum values with WebCore enum values

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54352





--- Comment #4 from Joone Hur <joone at kldp.org>  2011-02-13 15:30:26 PST ---
(In reply to comment #3)
> (From update of attachment 82259 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=82259&action=review
> 
> This is awesome, though we cannot break the ABI. Without the last change it's fine though.
> 
> > Source/WebKit/gtk/webkit/webkitwebview.h:64
> > +    WEBKIT_WEB_VIEW_VIEW_MODE_INVALID,
> 
> I think this might be an ABI break. :(

If we keep the ABI, the patch should be updated as follows,
But, I'm not sure if this is neat.

COMPILE_ASSERT_MATCHING_ENUM(WEBKIT_WEB_VIEW_VIEW_MODE_WINDOWED+1, Page::ViewModeWindowed);
COMPILE_ASSERT_MATCHING_ENUM(WEBKIT_WEB_VIEW_VIEW_MODE_FLOATING+1, Page::ViewModeFloating);
COMPILE_ASSERT_MATCHING_ENUM(WEBKIT_WEB_VIEW_VIEW_MODE_FULLSCREEN+1, Page::ViewModeFullscreen);
COMPILE_ASSERT_MATCHING_ENUM(WEBKIT_WEB_VIEW_VIEW_MODE_MAXIMIZED+1, Page::ViewModeMaximized);
COMPILE_ASSERT_MATCHING_ENUM(WEBKIT_WEB_VIEW_VIEW_MODE_MINIMIZED+1, Page::ViewModeMinimized);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.