[Webkit-unassigned] [Bug 53320] [Qt] QtWebKit does not properly handle D&D of a percent-encoded URL

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 13 06:23:47 PST 2011


Andreas Kling <kling at webkit.org> changed:

           What    |Removed                     |Added
  Attachment #82235|review?, commit-queue?      |review-
               Flag|                            |

--- Comment #8 from Andreas Kling <kling at webkit.org>  2011-02-13 06:23:47 PST ---
(From update of attachment 82235)
View in context: https://bugs.webkit.org/attachment.cgi?id=82235&action=review

Patch looks sensible, just one thing:

> Source/WebCore/platform/qt/DragDataQt.cpp:128
> +    return String(urls.first().toEncoded().constData());

You should use the String constructor that takes a length parameter in addition to the const char*, i.e:
QByteArray encodedUrl = urls.first().toEncoded();
return String(encodedUrl.constData(), encodedUrl.length());

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list