[Webkit-unassigned] [Bug 53728] indexeddb: make setVersion fire blocked event if other connections are open

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53728





--- Comment #13 from Jeremy Orlow <jorlow at chromium.org>  2011-02-11 15:57:29 PST ---
(From update of attachment 82197)
View in context: https://bugs.webkit.org/attachment.cgi?id=82197&action=review

almost there

> LayoutTests/storage/indexeddb/set_version_queue.html:84
> +    debug("inSetVersion2");

testPassed

> Source/WebCore/storage/IDBDatabaseBackendImpl.cpp:217
> +        prpCallbacks->onBlocked();

Usually the first thing we do in a function is assign the prp types to normal RefPtr types.  I know we don't do that some in these files, but we should probably try to get back to it.  So move that stuff up and then s/prpC/c/ here.

> Source/WebCore/storage/IDBDatabaseBackendImpl.cpp:218
> +        RefPtr<PendingSetVersionCall> pendingSetVersionCall = adoptRef(new PendingSetVersionCall);

the class should have a factory and new should be private.

> Source/WebCore/storage/IDBDatabaseBackendImpl.cpp:219
> +        pendingSetVersionCall->m_callbacks = prpCallbacks;

use callbacks

> Source/WebCore/storage/IDBDatabaseBackendImpl.cpp:269
> +    if (m_openConnectionCount == 1) {

Just do a return if > 1 so the rest isn't nested.  newline after the return too, i'd think

> Source/WebCore/storage/IDBDatabaseBackendImpl.cpp:271
> +            // FIXME: Do something better with ec?

ASSERT(!ec || whatever else it might be that's OK)...and remove the fixme

> Source/WebCore/storage/IDBDatabaseBackendImpl.h:102
> +    struct PendingSetVersionCall : RefCounted<PendingSetVersionCall> {

I'm not sure we really use structs much in WebKit.  Just forward declare the class here and define it in the .cpp

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.