[Webkit-unassigned] [Bug 54299] need makeContextCurrent() called in prepareForSoftwareDraw()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54299





--- Comment #12 from Vangelis Kokkevis <vangelis at chromium.org>  2011-02-11 15:22:46 PST ---
(In reply to comment #8)
> (In reply to comment #7)
> > (From update of attachment 82157 [details] [details])
> > I think we need to make the same change to ::prepareForHardwareDraw() as well.  In addition we need to replace:
> > #if ENABLE(SKIA_GPU) by #if ENABLE(ACCELERATED_2D_CANVAS) && ENABLE(SKIA_GPU)
> 
> prepareForHardwareDraw() is never reached in the skia GPU path

Good point! But then we have another problem... prepareForSoftwareDraw() isn't called before every call that renders via platformContext()->canvas() which means that there are calls  (e.g. GraphicsContext::clearRect()) which won't set the current GL context correctly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.