[Webkit-unassigned] [Bug 54313] DocumentThreadableLoader doesn't support WebURLLoader usage.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54313


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82178|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #8 from David Levin <levin at chromium.org>  2011-02-11 14:33:32 PST ---
(From update of attachment 82178)
View in context: https://bugs.webkit.org/attachment.cgi?id=82178&action=review

> Source/WebCore/ChangeLog:12
> +        (WebCore::DocumentThreadableLoader::didReceiveCachedMetadata):

A comment here would say:
  Make this method as protected instead of private.

I wonder why we just don't change the inheritance of SubresourceLoaderClient to be protected instead of private.

> Source/WebCore/ChangeLog:16
> +2011-02-11  Bill Budge  <bbudge at chromium.org>

This shouldn't be here.

> Source/WebCore/loader/DocumentThreadableLoader.h:58
> +        virtual void setDefersLoading(bool value);

No need for "value" here. (It adds no information.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.