[Webkit-unassigned] [Bug 46695] [Qt] Invalid pointer access & incomplete memcmp in setUpIterator

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46695





--- Comment #11 from chris reiss <christopher.reiss at nokia.com>  2011-02-11 13:01:05 PST ---
Created an attachment (id=82164)
 --> (https://bugs.webkit.org/attachment.cgi?id=82164&action=review)
Incomplete - seek feedback on this approach.

Curious to hear feedback on this approach to avoiding the deep string copy while safely reusing the TextIterator.    

I found that the big performance occurs hit occurs  down the stack from    
   RenderBlockLineLayout::findNextLineBreak, 
   WebCore::isBreakable, 
   WebCore::nextBreakablePosition and 
   WebCore::lineBreakIterator and finally to TextBreakIteratorQt.cpp.

Here i protect the memory using an optional argument and PassRefPtr .

Is this too disruptive?   Also - this patch isn't complete, some function signatures would need to change in other ports of TextIterator.   I just wanted to see if there were any fundamental objections to this approach before I roll up a complete patch.

i also have timing results comparing no caching, the current (unsafe) code, and this code if ppl are interested.   Also - Am i using PassRefPtr correctly?  It doesn't crash, anyway :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.