[Webkit-unassigned] [Bug 48510] [GTK] Implement WebEventFactory, WebErrors classes for WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48510





--- Comment #20 from Alejandro G. Castro <alex at igalia.com>  2011-02-11 09:27:01 PST ---
Thanks for both reviews, I'll check the remarks.

(In reply to comment #19)
> > Source/WebKit2/Shared/gtk/WebEventFactory.cpp:111
> > +    int sClickCount = 0;
> > +
> > +    switch (event->type) {
> > +    case GDK_BUTTON_PRESS:
> > +        sClickCount = 1;
> > +        break;
> > +    case GDK_2BUTTON_PRESS:
> > +        sClickCount = 2;
> > +        break;
> > +    case GDK_3BUTTON_PRESS:
> > +        sClickCount = 3;
> > +        break;
> > +    case GDK_MOTION_NOTIFY:
> > +    case GDK_BUTTON_RELEASE:
> > +        sClickCount = 0;
> > +        break;
> 
> This code is very suspicious. We need to support click counts higher than 3 and also to detect up front situations where GDK is sending both a GDK_BUTTON_PRESS followed closely by a GDK_3BUTTON_PRESS/GDK_2BUTTON_PRESS. See the code in webkitwebview.cpp to do this. My guess is that we'll need similar code in the widget and to pass in the click count manually.

We have a quite similar code already working in WebCore in MouseEventGtk.cpp. I'll check if it could cause any issue. Basic click combination at least work for the tests I did (except right click and menu popup)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.