[Webkit-unassigned] [Bug 54230] [GTK] Implement WebPage class for WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54230





--- Comment #5 from Alejandro G. Castro <alex at igalia.com>  2011-02-11 09:20:21 PST ---
(In reply to comment #2)
> (From update of attachment 82020 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=82020&action=review
> 
> > Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp:83
> > +static const KeyDownEntry keyDownEntries[] = {
> > +    { VK_LEFT,   0,                  "MoveLeft"                                    },
> > +    { VK_LEFT,   ShiftKey,           "MoveLeftAndModifySelection"                  },
> > +    { VK_LEFT,   CtrlKey,            "MoveWordLeft"                                },
> > +    { VK_LEFT,   CtrlKey | ShiftKey, "MoveWordLeftAndModifySelection"              },
> > +    { VK_RIGHT,  0,                  "MoveRight"                                   },
> > +    { VK_RIGHT,  ShiftKey,           "MoveRightAndModifySelection"                 },
> > +    { VK_RIGHT,  CtrlKey,            "MoveWordRight"                               },
> > +    { VK_RIGHT,  CtrlKey | ShiftKey, "MoveWordRightAndModifySelection"             },
> > +    { VK_UP,     0,                  "MoveUp"                                      },
> > +    { VK_UP,     ShiftKey,           "MoveUpAndModifySelection"                    },
> > +    { VK_PRIOR,  ShiftKey,           "MovePageUpAndModifySelection"                },
> > +    { VK_DOWN,   0,                  "MoveDown"                                    },
> 
> I think I'd rather see this done correctly up front than doing it quickly now and replacing it.  We probably need to plumb through to the UI process to do the mapping between key events and editor actions.

Good point, I think just mac is currently doing it, probably is why they decided to do leave it.

I have to review also compilation and check why we needed includes that other ports do not need.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.