[Webkit-unassigned] [Bug 48509] [GTK] Implement WebView and WebKitWebView classes for WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48509





--- Comment #30 from Alejandro G. Castro <alex at igalia.com>  2011-02-11 09:16:53 PST ---
Thanks for the review.

(In reply to comment #27)
> (From update of attachment 81961 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=81961&action=review
> 
> > Source/WebKit2/UIProcess/gtk/WebKitWebView.cpp:41
> > +    gboolean disposeHasRun;
> 
> disposeRan?
> 

Actually now that you point this out, I think I'm going to change this to the usual check of each variable in the gtkwidgets for the case were dispose is called multiple times.

> > Source/WebKit2/UIProcess/gtk/WebKitWebView.cpp:50
> > +    guint borderWidth = gtk_container_get_border_width(GTK_CONTAINER(widget));
> > +    gtk_widget_get_allocation(widget, &allocation);
> 
> Does it make sense for a WebView to have a border, since it isn't a container in the traditional sense?
>

I agree, we do not need it.

> > Source/WebKit2/UIProcess/gtk/WebView.cpp:144
> > +    return IntRect(m_viewRect).size();
> 
> Wouldn't it make sense to just ask the widget for its allocation here?

Yep, I think you are right, I had this in my list but I forgot to check it because it was the only reason to keep the gdkrectangle.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.