[Webkit-unassigned] [Bug 53564] Make canHaveChildrenForEditing more efficient

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53564





--- Comment #31 from Ryosuke Niwa <rniwa at webkit.org>  2011-02-11 06:40:22 PST ---
(In reply to comment #30)
> (In reply to comment #29)
> > Looking at the test (http://trac.webkit.org/browser/trunk/LayoutTests/editing/style/iframe-onload-crash.html), I don't see how this change can cause a crash only on GTK.  It's got to be some bug on GTK port.
> 
> Shouldn't runEnd.node()->canContainRangeEndPoint() be checked before attempting  textRunRange->setEnd() ?

It doesn't need to.  Even though the function name suggests that we should be doing that, Range code doesn't currently depend on canContainRangeEndPoint at all.  One thing you can try is to apply my patch but keep the original editingIgnoresContents and assert that the results are the same.  If that assert hits before the other one, then we'll be able to see what node is causing a problem.  If not, it's a bug in GTK DRT.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.