[Webkit-unassigned] [Bug 54257] Make DefaultGCActivityCallback for PLATFORM(CF) Easier to Subclass

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 10 17:18:32 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=54257





--- Comment #6 from Joseph Pecoraro <joepeck at webkit.org>  2011-02-10 17:18:32 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > > '\0' is a strange way to say '0'. I know you didn't write this code initially, but you might as well change it to '0'.
> > 
> > Done. Thanks!
> 
> I think Geoff meant to say pass 0, not '0'. Passing '0' to memset will initialize the memory to ASCII character 0.

Yes, entirely my fault. I took that literally. I landed a follow-up fix.
Unreviewed since initially this was a review comment.
http://trac.webkit.org/changeset/78292

Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list