[Webkit-unassigned] [Bug 54257] Make DefaultGCActivityCallback for PLATFORM(CF) Easier to Subclass

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54257





--- Comment #4 from Joseph Pecoraro <joepeck at webkit.org>  2011-02-10 17:10:44 PST ---
> > Source/JavaScriptCore/ChangeLog:8
> > +        A subclass may want to specify the CFRunLoop the Garbage Collection. It
> 
> Typo, I think.

Yep, I cleaned up my ChangeLog mistakes.

> > Source/JavaScriptCore/runtime/GCActivityCallbackCF.cpp:86
> > +    memset(&d->context, '\0', sizeof(CFRunLoopTimerContext));
> 
> '\0' is a strange way to say '0'. I know you didn't write this code initially, but you might as well change it to '0'.

Done. Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.