[Webkit-unassigned] [Bug 51152] <select> elements don't honor border:0px in chromium-linux

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 10 17:04:29 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=51152





--- Comment #15 from xiyuan <xiyuan at chromium.org>  2011-02-10 17:04:29 PST ---
(In reply to comment #14)
> xiyuan, can you review this?  The chromium side patch is http://codereview.chromium.org/6490014 .
> 
> I think the right way to land this two sided patch is:
> 1) land the webkit side first with the tests that need new baselines marked as failing.
> 2) wait for the change to be rolled into chromium
> 3) land the chromium side change
> 4) update webkit DEPS to pull in the chromium change, land the new baselines, and remove the test_expectations.txt lines

LGTM

Sorry that I made things are so complicated now. We might want to follow what win layout tests do, i.e. have a WebThemeEngine for layout test, to make things simple. 

Still not a committer to webkit so could not give you a review+. :p

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list