[Webkit-unassigned] [Bug 53911] Deploy EditingStyle in applyBlockStyle and applyInlineStyle
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 10 17:04:08 PST 2011
https://bugs.webkit.org/show_bug.cgi?id=53911
--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org> 2011-02-10 17:04:08 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > > Is this because of the changes to removeInlineStyle() at ApplyStyleCommand.cpp:917,921?
> >
> > Not really. The reason is that EditingStyle::style() can return a null-pointer, and these functions previously assumed that the style is always not null.
>
> I think the change is fine, but it would be nice if you had a test case that showed this possibility.
Oh, indeed some existing tests crash without this change because any test that inserts anchor element has null style pointer.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list