[Webkit-unassigned] [Bug 54257] Make DefaultGCActivityCallback for PLATFORM(CF) Easier to Subclass

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54257


Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82071|review?                     |review+
               Flag|                            |




--- Comment #2 from Geoffrey Garen <ggaren at apple.com>  2011-02-10 16:46:18 PST ---
(From update of attachment 82071)
View in context: https://bugs.webkit.org/attachment.cgi?id=82071&action=review

r=me

> Source/JavaScriptCore/ChangeLog:8
> +        A subclass may want to specify the CFRunLoop the Garbage Collection. It

Typo, I think.

> Source/JavaScriptCore/runtime/GCActivityCallbackCF.cpp:86
> +    memset(&d->context, '\0', sizeof(CFRunLoopTimerContext));

'\0' is a strange way to say '0'. I know you didn't write this code initially, but you might as well change it to '0'.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.