[Webkit-unassigned] [Bug 54224] toDataURL() fails if skia device is backed by GPU

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54224


James Robinson <jamesr at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82014|review?                     |review+
               Flag|                            |




--- Comment #5 from James Robinson <jamesr at chromium.org>  2011-02-10 15:46:18 PST ---
(From update of attachment 82014)
View in context: https://bugs.webkit.org/attachment.cgi?id=82014&action=review

Great!  Thanks for adding the test reference, it'll be useful to have this information if that test every breaks in the future.  Would you like me to c-q+ this as well?

> WebCore/platform/graphics/skia/ImageBufferSkia.cpp:354
> +    // if we can't see the pixels directly, call readPixels() to get a copy.
> +    // this could happen if the device is backed by a GPU.
> +    bitmap.lockPixels(); // balanced by our destructor, or explicitly if getPixels() fails

nit: In WebKit, comments start with an uppercase letter and end with a period.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.