[Webkit-unassigned] [Bug 54158] Throw exception when AudioContext's createBuffer() fails to properly decode audio file data

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54158


Kenneth Russell <kbr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81910|review?                     |review+
               Flag|                            |




--- Comment #3 from Kenneth Russell <kbr at google.com>  2011-02-10 15:11:57 PST ---
(From update of attachment 81910)
View in context: https://bugs.webkit.org/attachment.cgi?id=81910&action=review

Looks fine to me. One minor comment.

> Source/WebCore/bindings/js/JSAudioContextCustom.cpp:73
> +        if (arrayBuffer) {

To make the JSC and V8 bindings identical you should ASSERT(arrayBuffer) here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.