[Webkit-unassigned] [Bug 53868] [Qt] fast/notifications/notifications-document-close-crash.html fails after r77738

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53868


Robert Hogan <robert at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |japhet at chromium.org,
                   |                            |zmo at google.com




--- Comment #4 from Robert Hogan <robert at webkit.org>  2011-02-10 14:14:19 PST ---
This test is flaky on Chromium now. 

Until r77738 the test could depend on the ScriptExecutionContext being null because NotificationCenter held a local copy which got nulled on NotificationCenter::disconnectFrame(). Now NotificationCenter will return a valid ScriptExecutionContext until the Document/ScriptExecutionContext the DomWindow originally associated it with is destroyed.

I believe the reason Qt is now failing on 'if (!exec->argument(0).isObject())' instead is because 'script()->clearScriptObjects();' has been called in 'void Frame::pageDestroyed()' on the way to calling NotificationCenter::disconnectFrame(). So any crash is still safely avoided.

Unless there's a good reason to expect the Document/ScriptExecutionContext to be destroyed by the time notification.RequestPermission() is called in the test the new result is valid.

Can anyone point to why it should be destroyed by that time?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.