[Webkit-unassigned] [Bug 53766] [Qt] Compilation error on OpenBSD

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53766


Patrick R. Gansterer <paroga at paroga.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82034|                            |review?, commit-queue?
               Flag|                            |




--- Comment #7 from Patrick R. Gansterer <paroga at paroga.com>  2011-02-10 13:21:19 PST ---
Created an attachment (id=82034)
 --> (https://bugs.webkit.org/attachment.cgi?id=82034&action=review)
Alternative Patch (with positiv listing)

View in context: https://bugs.webkit.org/attachment.cgi?id=82021&action=review

>> Source/JavaScriptCore/wtf/Platform.h:729
>> +#if !COMPILER(MSVC) && !COMPILER(RVCT) && !OS(WINDOWS) && !OS(LINUX) && !OS(SOLARIS) && !OS(OPENBSD)
> 
> Shouldn't that be the other way around:
> #if OS(MAC) || OS(FREEBSD)
> ?

Maybe yes, maybe no. ;-)
I don't know if it's defined at AIX, HAIKU, NETBSD, QNX, but changing this to positiv listing is clearly better.

It seams that at least HAIKU needs this change too, so it's ok to take the risk of breaking the build on some "uncommon" platforms IMHO.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.