[Webkit-unassigned] [Bug 54146] User generated events may not fire properly due to garbage collection

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 10 11:24:44 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=54146





--- Comment #4 from Jeremy Orlow <jorlow at chromium.org>  2011-02-10 11:24:43 PST ---
(In reply to comment #3)
> > use some stashed handle of a parent object and use an event that captures/bubbles
> 
> I believe that you are talking about nodes in a document tree here. These don't have their wrappers collected as long as they have custom properties or event handles (see isObservableThroughDOM() in JSDOMBinding.cpp). So I don't think that there is a problem here.

I'm talking about objects like IDBRequest or FileWriter, not nodes or anything in a document tree.

> We certainly have known and unknown cases that aren't handled properly - see e.g. bug 34231. Another example is nodes in undo/redo stack. These are edge cases, but it would be nice to fix them. Unless you are looking for a general solution (and currently, this code isn't quite centralized), separate bugs with specific examples are preferable.

I cited a specific bug that I'm fixing.  It seems like this is a more general issue though.  I've been working on APIs like this within WebKit for 2 years and I had no clue these pitfalls existed.  My guess is that most other contributors don't as well and others will have the same issues.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list