[Webkit-unassigned] [Bug 54080] [GTK] Implement UpdateChunk, ChunkedUpdateDrawingArea/Proxy classes for WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54080


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mrobinson at webkit.org




--- Comment #7 from Martin Robinson <mrobinson at webkit.org>  2011-02-10 09:51:22 PST ---
(In reply to comment #6)
> The patch looks good to me except for the following usage:
> View in context: https://bugs.webkit.org/attachment.cgi?id=81959&action=review
> 
> > Source/WebKit2/UIProcess/gtk/ChunkedUpdateDrawingAreaProxyGtk.cpp:80
> > +    RefPtr<cairo_surface_t> pixmap(updateChunk->createImage());
> 
> I am not sure if this is supported. cairo_destroy_surface has to be explicitly called, I think.
> 
> > Source/WebKit2/WebProcess/WebPage/gtk/ChunkedUpdateDrawingAreaGtk.cpp:46
> > +    RefPtr<cairo_surface_t> image = updateChunk->createImage();
> 
> Same here.
> 
> > Source/WebKit2/WebProcess/WebPage/gtk/ChunkedUpdateDrawingAreaGtk.cpp:47
> > +    RefPtr<cairo_t> cr = cairo_create(image.get());
> 
> And here. cairo_destroy has to be called.

RefPtrCairo defines some specializations for Cairo + RefPtrs, unless I'm missing something.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.